Unexpected identifier in Javascript Object

Question

I am creating the following object:

  var IOBreadcrumb = {
    breadcrumbs: []

    add: function(title, url){
      var crumb = {title, url};
      this.breadcrumbs.push(crumb);
    }
  };

I am getting an unexpected identifier error. Not really sure where it is coming from, its in this block of code.

jslint is your friend. It will give you line and column numbers of your syntax error. — hurrymaplelad
– hurrymaplelad, Commented Oct 5, 2011 at 23:13
@hurrymaplelad No need for an external tool. The browser itself does give you the line number of the error (and other details). — Šime Vidas
– Šime Vidas, Commented Oct 5, 2011 at 23:21

lonesomeday · Accepted Answer · 2011-10-05 23:16:00Z

3

You need a comma between members of your object, which is the cause of the error you cite. You also need to put a colon, rather than a comma, between the key-value pair in the crumb object.

var IOBreadcrumb = {
  breadcrumbs: [], // <-- comma here

  add: function(title, url){
    var crumb = {title: url}; // <-- colon here
    this.breadcrumbs.push(crumb);
  }
};

If you want an object where there are two members, one the title and one the URL, you may want something like this:

var crumb = {
  title: title,
  url: url
};

I don't know whether that would work with your breadcrumbs setup...

edited Oct 5, 2011 at 23:16

answered Oct 5, 2011 at 23:10

lonesomeday

239k54 gold badges330 silver badges329 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sheehan Alam Over a year ago

i would like a crumb to have both a title and a url, not sure how i can represent that as a JSON, or as another data structure?

Sheehan Alam Over a year ago

should it be {'title':title,'url':url} since I want to have a title and a url for a crumb?

hurrymaplelad Over a year ago

yep: var crumb = {title: '', url: ''};

Šime Vidas · Accepted Answer · 2011-10-05 23:19:53Z

2

I believe you want this:

var IOBreadcrumb = {
    breadcrumbs: [],
    add: function ( title, url ) {
        var crumb = {};
        crumb[ title ] = url;
        this.breadcrumbs.push( crumb );
    }
};

answered Oct 5, 2011 at 23:19

Šime Vidas

187k66 gold badges290 silver badges392 bronze badges

Collectives™ on Stack Overflow

Unexpected identifier in Javascript Object

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related