PHP - PHPDoc typehint when trying to iterate over integer

Question

I have this code

/** @var array{total: integer, records: array} $response */
$response = $this->getResponse();

foreach($response['total'] as $value) {
    $this->saveRecord($value);
}

Shouldn't PhpStorm give me a warning using PHPDoc static analysis that I'm trying to iterate over $response['total'], which is an integer ?

I added the PHPStorm tag to your question because this is a question about that IDE. — KIKO Software
– KIKO Software, Commented Oct 31, 2023 at 9:43
FWIW, phpstan.org/writing-php-code/phpdoc-types#array-shapes agrees with you. — Ulrich Eckhardt
– Ulrich Eckhardt, Commented Oct 31, 2023 at 13:01

Eugene Morozov · Accepted Answer · 2023-11-01 16:03:07Z

0

At the moment, we add the mixed type to all array shapes, that is why the inspection isn't triggered.

You can check what type any symbol holds by selecting it and clicking View | Type Info.

Please vote for WI-61678.

edited Nov 1, 2023 at 16:03

answered Nov 1, 2023 at 14:28

Eugene Morozov

3,0531 gold badge13 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

LazyOne Over a year ago

Not sure on this (why array<int>?)... unless I've got the initial example completely wrong...

Eugene Morozov Over a year ago

I totally missed what the question was about. It's about the fact that the OP can iterate over an integer, and not about $value holding the wrong type (even though the root cause is the same). Thank you, I've corrected the answer

Collectives™ on Stack Overflow

PHP - PHPDoc typehint when trying to iterate over integer

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related