Replacing specified characters using Regex .net

Question

I have a small Regex here where I am removing all the white spaces from within a file and replacing them with '-'.

I want to also replace other characters with '-' such as ',' and '_'.

How can I list these characters in my regex?

Regex r = new Regex(@"\s+");

string fileName = r.Replace(Files.Name, @"-");

xanatos · Accepted Answer · 2011-10-19 12:21:35Z

4

Regex r = new Regex(@"[\s,_-]+");

string fileName = r.Replace(Files.Name, @"-");

Be aware that the - must be the first, the last or you'll need escaping.

edited Oct 19, 2011 at 12:21

answered Oct 19, 2011 at 12:12

xanatos

112k13 gold badges209 silver badges297 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

xanatos Over a year ago

@FailedDev It was a pedantic with a :-) or a :-D... A pe :-D antic

FailedDev Over a year ago

Just saying :) no offense intended! :)

Michael Low · Accepted Answer · 2011-10-19 12:01:12Z

3

Regex r = new Regex(@"(\s|-|,|_)+");

answered Oct 19, 2011 at 12:01

Michael Low

24.6k17 gold badges85 silver badges119 bronze badges

2 Comments

Tim Pietzcker Over a year ago

Uh, but that's an inefficent way to do it. @xanatos' version is cleaner and faster.

Michael Low Over a year ago

I think it's more readable as you don't need to worry about ordering or escaping characters, but that's personal preference. I think we're way into micro-optimization to call this 'inefficient' though. Yes, it may be a few milli-seconds slower if you loop over it thousands of times. Does that matter ? If absolute fastest is needed, straight string replace for each of the various characters would be faster still. Readability would generally be more important IMO.

Collectives™ on Stack Overflow

Replacing specified characters using Regex .net

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related