GridSeachCV custom profit function results with an error: missing 1 required positional argument: 'y'

Question

I am trying to optimize my model with GridSearchCV, using a custom profit function. However, when I Run my code, I end up with the following error message: TypeError: profit_scorer() missing 1 required positional argument: 'y''

Here is my code:

sale_revenue = 11
call_cost = 3
false_positive_cost = call_cost

def calculate_profit(y_true, y_pred):
    tn, fp, fn, tp= confusion_matrix(y_true, y_pred).ravel() #tn, fp, fn, tp
    profit_from_sales = tp * (sale_revenue - call_cost)
    loss_from_wasted_calls = fp * false_positive_cost
    total_profit = profit_from_sales - loss_from_wasted_calls
    return total_profit

def profit_scorer(estimator, X, y):
    y_pred = estimator.predict(X)
    return calculate_profit(y, y_pred)

scorer = make_scorer(profit_scorer, greater_is_better=True)

rf = RandomForestClassifier(random_state=42, class_weight="balanced")

param_grid = {
    'n_estimators': [50, 100, 200],
    'max_depth': [3,4,5],
    'criterion': ['gini', 'entropy'],
    'max_features': ['sqrt', 'log2'],
    'bootstrap': [True, False]}

grid_search = GridSearchCV(
    estimator=rf,
    param_grid=param_grid, 
    cv=5, 
    scoring= scorer, 
    verbose=1)
grid_search.fit(X, y)`

Don't make us guess where the error happens. Please update your question and add the full error traceback message. — John Gordon
– John Gordon, Commented Jan 24 at 13:01
Sorry for the inconvenience, it was my first time asking a question on stackoverflow. Thanks for the constructive feedback! — user29348541
– user29348541, Commented Jan 24 at 15:19

dx2-66 · Accepted Answer · 2025-01-24 14:12:10Z

0

According to the docs, the profit_scorer() should have a signature of profit_scorer(y, y_pred, **kwargs).

make_scorer() transforms it into scorer(estimator, X, y_true, **kwargs).

Changing the profit_scorer() declaration to:

def profit_scorer(y_true, y_pred):
    return calculate_profit(y_true, y_pred)

Should suffice.

answered Jan 24 at 14:12

dx2-66

2,9352 gold badges9 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

GridSeachCV custom profit function results with an error: missing 1 required positional argument: 'y'

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related