Not able to call a JavaScript function from PHP code?

Question

How do I call a JavaScript function from href tag in html? I've created a few tabs and when a user clicks on one of them the href along with JavaScript function should get called.

<?php if($order == 1){ ?>
<li class="cat-one">
    <a href="javascript:void(0)" onclick="loadProducts(<?php echo $categoryId ?>)"> 
        <?php echo $categoryName ?> 
    </a>
</li>
<?php } ?>

This is my JavaScript:

function loadProducts($categoryId)
{
    alert("Hello World!");
    return false;
}

Why doesn't the alert trigger in my function? I am running 2 jQueries on the same page.

Visit the page, view source and look for errors in the part you have mentioned. Is categoryId an integer? You didnt surround it with quotes so unless it is, javascript will see something like loadProducts(IAmACategoryId); which will fail. What javascript error do you get when you click the link? — James
– James, Commented Nov 16, 2011 at 14:21

Niels · Accepted Answer · 2011-11-16 12:03:23Z

2

What if you try this:

<a href="#" onclick="loadProducts(<?php echo $categoryId ?>); return false;">

answered Nov 16, 2011 at 12:03

Niels

50.1k4 gold badges68 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ysrb · Accepted Answer · 2011-11-16 12:08:14Z

0

Try:

<script type="javascript" >
function loadProducts(categoryId)
{
alert("Hello World!" + categoryId);
return false;
}

</script>

And also:

<a href="#" onclick="loadProducts(<?php echo $categoryId ?>); return false;" > 
  <?php echo $categoryName ?> 
</a>

edited Nov 16, 2011 at 12:08

answered Nov 16, 2011 at 12:02

ysrb

6,7202 gold badges32 silver badges30 bronze badges

2 Comments

PeeHaa Over a year ago

Why can't he do function loadProducts($categoryId) {? Or am I missing something?

RickN Over a year ago

@PeeHaa: While variables can begin with a dollar sign in JavaScript, it is not mandatory and not often used. Here is a question about when to use a dollar sign in a variable name in JavaScript.

Sumair Zafar · Accepted Answer · 2011-11-16 12:09:10Z

0

I just checked the JavaScript, you make a mistake while declaring script tag, the correct code is below

<script type="text/javascript" >
function loadProducts($categoryId)
{
alert("Hello World!");
return false;
}
</script>

answered Nov 16, 2011 at 12:09

Sumair Zafar

988 bronze badges

Comments

Robert Wilson · Accepted Answer · 2011-11-16 12:11:15Z

0

From your script above I really don't see nothing wrong with the JavaScript. Try debugging your PHP first to see if the expected value like ($categoryId) is exactly what you expect to be.

Your are missing something also from the script tag

<script type="text/javascript">
// Your script goes here... 
</script>

answered Nov 16, 2011 at 12:11

Robert Wilson

6691 gold badge14 silver badges30 bronze badges

Comments

Anish · Accepted Answer · 2011-11-16 17:02:03Z

0

May be your php script has some errors, Try this example also.

<html>
<body>
<script type= "text/javascript">
function loadProducts(catid){
    alert(""Hello World!"+catid);
    return false;
}
</script>


<?php if($order == 1){ ?>
<li class="cat-one">
    <a href="javascript:void(0)" onclick="loadProducts(<?php echo $categoryId ?>)"><?php echo $categoryName ?> </a>
</li> 

</body>
</html>

answered Nov 16, 2011 at 17:02

Anish

5,4487 gold badges39 silver badges61 bronze badges

Comments

theEdgeOfChaos · Accepted Answer · 2011-11-18 21:24:08Z

0

From what I can tell without actually running this code, you can fix a few semi-colons on lines 3 and 4, change the href, and put the parameter for loadProducts in quotes. Try this:

<?php if($order == 1){ ?>
<li class="cat-one">
    <a href="#" onclick="loadProducts('<?php echo $categoryId; ?>')"> 
        <?php echo $categoryName; ?> 
    </a>
</li>
<?php } ?>

Let me know if it works out for you.

answered Nov 18, 2011 at 21:24

theEdgeOfChaos

994 bronze badges

Collectives™ on Stack Overflow

Not able to call a JavaScript function from PHP code?

6 Answers 6

Comments

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related