Dynamic Javascript File newline & carriage return

Question

I am building a JS page dynamically with php using .htaccss to make .php into .js

All works well apart from the output of the JS.

IE

$data = array('one', 'two');

foreach($data as $d){
    echo "document.write('This is a test for array item ".$d."'); \r\n";
}

Problem is it outputs it all on one line ie

document.write('This is a test for array one');document.write('This is a test for array two');

No matter what I have tried I cant get it over 2 lines.

Any ideas ?

Neall · Accepted Answer · 2009-05-06 12:39:00Z

2

Edit: It looks like I misunderstood the question - he was having trouble with newlines in his JS, not his final HTML.

Your JavaScript is coming out on separate lines because of the "\r\n" at the end of the string, but then you're outputting plain text into your HTML document. HTML does not break lines unless you're in a pre-formatted block (like "<pre>") or you give it an explicit break (like "<br>").

You probably want your code to look like this:

foreach($data as $d){
  echo "document.write('This is a test for array item ".$d."<br>'); \r\n";
}

Just be very careful of your data - inserting random strings into your HTML is a fast way to get security holes.

edited May 6, 2009 at 12:39

answered May 6, 2009 at 11:49

Neall

27.3k5 gold badges51 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Hexagon Theory Over a year ago

Fail, dude... it bugs me when people peddle false information with such certitude. : /

Lee Over a year ago

Im not actually worried about the inner content new line as that would ust be html like you have said. Its getting the document.write on to new lines.

Neall Over a year ago

It looks like I misunderstood the question. I ran the exact code you posted, and the document.writes come out on separate lines. Are you sure you don't have some sort of JavaScript compression layer on your web server? Are you sure that your web browser isn't munging the code for you? Try downloading the JS with wget or some other command-line utility.

Neall Over a year ago

Just for the record, was the browser the problem?

Hexagon Theory · Accepted Answer · 2009-05-06 11:52:58Z

0

Heh, actually, I think if you view the source of the generated file you will find that the line breaks are indeed there. : )

answered May 6, 2009 at 11:52

Hexagon Theory

44.9k6 gold badges28 silver badges30 bronze badges

Collectives™ on Stack Overflow

Dynamic Javascript File newline & carriage return

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related