javascript issue in C#

Question

I write this coding in C# in my sharepoint project. It works well.

ClientScript.RegisterStartupScript(this.GetType(), "ale", "window.open('DownloadHandler.ashx?fileName=Error.log');", true);

But when I change my coding to this, it no longer works.

ClientScript.RegisterStartupScript(this.GetType(), "ale", string.Format("window.open('DownloadHandler.ashx?fileName={0}')", "Error.log"), true);

What's wrong with my coding?

I don't know, there's a missing ; at the end of the window.open() statement? — Jared Farrish
– Jared Farrish, Commented Dec 27, 2011 at 3:07

Jared Farrish · Accepted Answer · 2011-12-27 03:13:05Z

2

There's a missing ; at the end of the window.open() statement:

ClientScript.RegisterStartupScript(
    this.GetType(), 
    "ale", 
    string.Format("window.open('DownloadHandler.ashx?fileName={0}');", "Error.log"),
    true
);

answered Dec 27, 2011 at 3:13

Jared Farrish

49.4k17 gold badges100 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Peter Olson Over a year ago

I'm curious as to why this lack of a semicolon would cause it to stop working, since Javascript has automatic semicolon insertion.

Jared Farrish Over a year ago

@PeterOlson - I'm not sure, since I was thinking the same thing (minor error in Javascript). Maybe IE throws an error and stops execution if a statement is not ended? I'm wondering the same thing. It was the only problem I saw with the example code.

Tomislav Markovski Over a year ago

Script registrar may have other scripts after it which are added together, thus rendering the script in error. This script string is processed by .net before it is executed by javascript.

Jared Farrish Over a year ago

@TomislavMarkovski - That was my second guess, which was something else was happening that threw the actual on-page script off. Always best to inspect what the browser sees vis-a-vis Javascript.

Tomislav Markovski · Accepted Answer · 2011-12-27 03:14:13Z

1

So it's missing a semi colon ; at the end.

ClientScript.RegisterStartupScript(this.GetType(), "ale", string.Format("window.open('DownloadHandler.ashx?fileName={0}');", "Error.log"), true);

answered Dec 27, 2011 at 3:14

Tomislav Markovski

12.4k7 gold badges53 silver badges75 bronze badges

Collectives™ on Stack Overflow

javascript issue in C#

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related