Javascript function call with arguments

Question

I am developing a mobile application using phonegap and jquery mobile. I have this function which has to pass a variable to another function. It goes something like this:

    $.each(response.records, function(i, contact) {
       var url = contact.Id;
       var newLi = $("<li><a href='javascript:dothis("+url+")'>" + (i+1) + " - " + contact.Name + " - Company "+contact.Company+"</a></li>");
           ul.append(newLi);}

I have the dothis(argument) function but it does not get called when i put in the variable "url". When i erase the argument, it works. Please Help!

Community · Accepted Answer · 2017-05-23 12:21:12Z

3

It's definitely not good practice to use the javascript: protocol in href attributes. It's much better to bind events to the links and respond accordingly.

Insert something like this after you append newLi to the ul:

$.find('a').bind('click', function() {
    dothis(url);
});

Here's some more info about why it's bad practice to use the javascript: protocol: Why is it bad practice to use links with the javascript: "protocol"?

edited May 23, 2017 at 12:21

CommunityBot

11 silver badge

answered Jan 12, 2012 at 8:18

Philip Walton

30.5k16 gold badges65 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user790514 Over a year ago

thanks Philip Walton. I guess i was going for the 1990's thing :(

craigmj · Accepted Answer · 2012-01-12 08:17:32Z

1

You need to put the url in quotes in the javascript:

var newLi = $("<li><a href=\"javascript:dothis('" +
      url +
      "')\">" + 
      (i+1) + " - " + contact.Name + 
      " - Company " + contact.Company + "</a></li>");

You might need to consider escaping the URL so that, if it contains any difficult characters, your javascript won't break.

answered Jan 12, 2012 at 8:17

craigmj

5,1272 gold badges21 silver badges22 bronze badges

Collectives™ on Stack Overflow

Javascript function call with arguments

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related