Javascript syntax problems

Question

I am creating a new literal control from code behind, I add standard html into it which works fine. I try to add <%= SomeDiv.ClientID %> into this literal control but it quite literally prints into source exactly whats in code behind.

Code behind:

new LiteralControl("<div id='" + paneID.Replace(" ", "") + "_Expand' runat='server' onclick='ChangePanelHeader(&#39;<%= " + paneID.Replace(" ", "") + "_Expand.ClientID %>&#39;" + ", " + "&#39;<%= " + paneID.Replace(" ", "") + "_cpe.ClientID %>&#39;)' class='rhsCollapsiblePanelsHeader'>" + paneTitle + "<br /><br /></div>" + paneContent)

In Browser Source once page is loaded:

<div id='Tellafriend_Expand' runat='server' onclick='ChangePanelHeader(&#39;<%= Tellafriend_Expand.ClientID %>&#39;, &#39;<%= Tellafriend_cpe.ClientID %>&#39;)' class='rhsCollapsiblePanelsHeader'>Tell a friend<br /><br /></div>

Wanted result:

<div id='Tellafriend_Expand' runat='server' onclick='ChangePanelHeader("MyTelAFriendID_Expand", "MyTelAFriendID_cpe") class='rhsCollapsiblePanelsHeader'>Tell a friend<br /><br /></div>

Firefox syntax error:

syntax error
[Break On This Error]   

ChangePanelHeader(<%= Tellafriend_Expand.ClientID %>, <%= Tellafriend_cpe.Cli...

default.aspx (line 1, col 20)

nnnnnn · Accepted Answer · 2012-02-28 02:08:46Z

2

(After my initial "Huh?") I notice you're getting your server-side code to output ids that are not wrapped in quotes. In JS those ids likely need to be treated as strings, so try this:

ChangePanelHeader("<%= Tellafriend_Expand.ClientID %>", ...);
// add quotes ----^----------------------------------^

(If that's not it, well, I'll wait for the question rewrite promised in your comment.)

answered Feb 28, 2012 at 2:08

nnnnnn

150k30 gold badges210 silver badges247 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Anicho Over a year ago

Thanks mate, sorry its 3 am in the morning in the uk. I have rewritten it let me know if you require anything else.

nnnnnn Over a year ago

You've embedded the <%= within your server-side string literals, so that's why it all ends up in the source the browser sees. I haven't really done anything with ASP code-behind so I'm not sure how to achieve the effect you want - I gather you want to dynamically generate the name of an object and then get the .ClientID of that object?

Anicho Over a year ago

Yep I have just noticed I can get it in code behind using Object.ClientID I will see what this produces

Anicho Over a year ago

Instead of <%= object.ClientID %> you can just do Object.ClientID in code behind, also in stead of ' i just did \" I should of been escaping characters from the start.

nnnnnn Over a year ago

I nearly updated my answer to suggest exactly that, but it looked to me like you were building the name of the object by taking the string from paneID.Replace() and adding "_expand" on the end, and I wasn't sure about how to deal with that part.

Collectives™ on Stack Overflow

Javascript syntax problems

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related