sending a php variable to onclick event

Question

can i send a php variable to my javascript function using onclick event of a link like this

<a onclick="change(<?php echo $description ?>)">

when I echo the description it is available but when I send it to my javascript function it says undefined

How can I do this ?

Thanks

Use a JSON encoding routine to encode the description. That'll add quotes and check for embedded quotes. — Pointy
– Pointy, Commented Mar 23, 2012 at 13:24
not working :( i get an empty alet inside my javascript function — Faryal Khan
– Faryal Khan, Commented Mar 23, 2012 at 13:29

George Cummins · Accepted Answer · 2012-03-23 13:27:07Z

3

$description is probably a string, so you need quotes around it in your Javascript:

<a onclick="change('<?php echo $description ?>')">

edited Mar 23, 2012 at 13:27

George Cummins

29k8 gold badges74 silver badges91 bronze badges

answered Mar 23, 2012 at 13:25

Paul

142k28 gold badges285 silver badges272 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Paul Over a year ago

Also take a look at "Unobtrusive Javascript". It is better to separate your Javascript from your HTML

George Cummins Over a year ago

Since we can't see your output, "not working" is not enough information for us to provide useful answers. Please update your question or your comment to provide full details: what do you expect to happen, what you tried (exactly), and what really happened (errors, etc).

Faryal Khan Over a year ago

I have just a javascript function change function change(desc) alert(desc) nothing else in javascript

Paul Over a year ago

Do <?php var_dump($description); ?> and tell us what it says

Faryal Khan Over a year ago

@George Cummins It is not showing me the alert in which i want to display the description. when I use hardcoded string it shows the alert... I think there is some problem in the data that comes from the database... It contains some html tags when it comes from database can I remove all the tags first and then pass the string only ?

|

NDBoost · Accepted Answer · 2012-03-23 13:36:38Z

you can easily do this in jquery.. if you're interested in using another library such as jquery..

Js

var description;
$('#description').click(function(){
  description = $(this).val();
  //alternatively you can use data-description and retrieve it like so:
  description = $(this).data('description');
  //if that doesnt work use attr();
  description = $(this).attr('data-description');
  //this will return "My awesome description"
  console.log(description);
}

php

<?php 
$description = 'My awesome description';
?>

html

<a id="description" href="#"><?= $description; ?></a>
<!-- alternatively you could used data-description attribute on the href and pass that.. -->
<a href="#" data-description="<?= $description; ?>">Link 1</a>

Collectives™ on Stack Overflow

sending a php variable to onclick event

2 Answers 2

6 Comments

Js

php

html

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Js

php

html

Comments

Your Answer

Sign up or log in

Post as a guest

Related