MySQL Query INSERT INTO issue

Question

$sql="INSERT INTO (CLL_users) SET last_login= $dateCreated WHERE username= $username";
$result=mysql_query($sql);

Here is the entire code of the page loaded after successful validation and I do realize its the worst method to use because of SQL injection but once I get the proper query down I will recode it for PDO prepared statements this was just an example I found on another website and I am modifying it to add the last_login parameter.

<?php
session_start();
$host="localhost"; // Host name 
$username="user"; // Mysql username 
$password="XXXXX"; // Mysql password 
$db_name="DB"; // Database name 
$tbl_name="users"; // Table name 
date_default_timezone_set('America/Chicago');
$dateCreated = date('m/d/Y h:i:s a', time());

mysql_connect("$host", "$username", "$password")or die("cannot connect"); 
mysql_select_db("$db_name")or die("cannot select DB");

$sql="INSERT INTO (CLL_users) SET last_login= $dateCreated WHERE username= $username";
$result=mysql_query($sql);

if(!session_is_registered(myusername)){
header("location:main_login.php");
}
?>

<html>
    <head>
        <title> Welcome</title>

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
            <LINK href="CLL.css" rel="stylesheet" type="text/css">
    </head>
 <body>
     <?php echo $dateCreated ?>
<p>Login Successful</p>
</body>
</html>

You didn't really specify the problem you're having. Are you getting an error? If so, what error? — user462356
– user462356, Commented Nov 1, 2012 at 3:47
The problem is that it is not updating the database I am not getting any error and if I echo the variable that has the date stored in it, it will echo properly. I am unsure my query is correct for updating the database I have tried several different methods with no luck, — Yamaha32088
– Yamaha32088, Commented Nov 1, 2012 at 3:48
@Yamaha32088 INSERT create a new entry in database. For update you need to use UPDATE.. — Gabriel Santos
– Gabriel Santos, Commented Nov 1, 2012 at 3:57

Jarod Elliott · Accepted Answer · 2012-11-01 03:47:29Z

2

You will need single quotes around you dateCreated and username variables.

Also, you need to use an update statement to update an existing record rather than doing an insert. If you echo the $sql variable you will see that your insert statement isn't valid and wont work if you try to run it manually on the database.

eg. $sql="UPDATE CLL_users SET last_login='$dateCreated' WHERE username='$username'";

answered Nov 1, 2012 at 3:47

Jarod Elliott

15.7k3 gold badges37 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

slash28cu · Accepted Answer · 2012-11-01 03:50:21Z

2

Well first of all i will suggest to surround you variables with single quotes and next i will suggest you to use the following syntax for your insert. INSERT INTO table (COLUMN1, COLUMN2,COLUMN3) VALUES('value1','value2','value3')

Also replace INSERT INTO for UPDATE if what you want is update the row rather than insert something.

answered Nov 1, 2012 at 3:50

slash28cu

1,63412 silver badges23 bronze badges

Comments

Vikas Umrao · Accepted Answer · 2012-11-01 03:51:14Z

2

$sql="update CLL_users SET last_login= $dateCreated WHERE username= $username";
$result=mysql_query($sql);

answered Nov 1, 2012 at 3:51

Vikas Umrao

2,5801 gold badge17 silver badges23 bronze badges

Comments

thar45 · Accepted Answer · 2012-11-01 03:52:29Z

2

Cause of error is, you dont have insert query with Set option if you would like to update the table follow this for sql variable

 $sql = "UPDATE CLL_users SET last_login= '$dateCreated' WHERE username='$username'";

Document For Insert Document for update

answered Nov 1, 2012 at 3:52

thar45

3,5705 gold badges35 silver badges49 bronze badges

Comments

Muthu Kumaran · Accepted Answer · 2012-11-01 03:55:18Z

1

You can't use INSERT to update existing records in the table. Use UPDATE query

$sql="UPDATE CLL_users SET last_login= '$dateCreated' WHERE username= '$username'";

edited Nov 1, 2012 at 3:55

answered Nov 1, 2012 at 3:48

Muthu Kumaran

18k5 gold badges50 silver badges72 bronze badges

1 Comment

Yamaha32088 Over a year ago

Thank you for the help I actually found more then just my error of using the INSERT statement. I overlooked the fact that I was calling the username variable of the database and not the username of the logged in user. Also I had an under_score between user and name in the database but my query was just "username".

Collectives™ on Stack Overflow

MySQL Query INSERT INTO issue

5 Answers 5

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related