Arrays stringing numbers

Question

package javaapplication1;

/**
 *
 * @author
 */
public class JavaApplication1 {

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        int[] scores = {1,2,3,4,5,6};
        int[] fin = extractAllEvens(scores);
        for(int i =0; i<fin.length; i++) {
            System.out.println(fin[i]);
    }
    }
        public static int[] extractAllEvens(int[]scores) {
            int evenCount = 0;
            for (int i =0; i<scores.length; i++) {
                if (scores[i] % 2 ==0) {
                    evenCount++;
                }
        }
        int[] newScores = new int[evenCount];
        int j = 0;
        for(int i = 0; i<scores.length; i++) {

            if(scores[1] % 2 ==0) {
            newScores[1] = scores[i];
            j++;
            }
        }
    return newScores;
}
}

I'm trying to output 2, 4, 6.

But I keep getting results such as 0,6,0.

I think I messed up somewhere with the variables with i or j or the number 1 and possibly their locations... can anyone help lead me in the right direction?

Some programmer dude · Accepted Answer · 2017-03-08 18:28:26Z

1

scores[1] % 2 == 0 and newScores[1] = scores[i]?

You have hard-coded to use only index 1 (the second element) of newArray.

You probably should be using j as the index instead of 1.

answered Mar 8, 2017 at 18:28

Some programmer dude

411k36 gold badges420 silver badges655 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

GhostCat · Accepted Answer · 2017-03-08 18:28:23Z

0

Your last loop uses 1 as fixed loop index.

Change that to i instead.

answered Mar 8, 2017 at 18:28

GhostCat

141k28 gold badges191 silver badges262 bronze badges

2 Comments

minigeek Over a year ago

ummm one should be i and other one j :)

GhostCat Over a year ago

You are right. And the real take away us:the op should try writing less confusing code in the first place :-)

Vijayan Kani · Accepted Answer · 2017-03-08 18:31:18Z

0

Change the second for loop like this -

for (int i = 0; i < scores.length; i++) {
        if (scores[i] % 2 == 0) {
            newScores[j] = scores[i];
            j++;
        }
    }

Cheers!

answered Mar 8, 2017 at 18:31

Vijayan Kani

3683 silver badges9 bronze badges

Comments

minigeek · Accepted Answer · 2017-03-09 03:31:18Z

0

instead of

if(scores[1] % 2 ==0) {
        newScores[1] = scores[i];

It should be

if(scores[i] % 2 ==0) {//← i here
        newScores[j] = scores[i];//← j here

O/P : 2 4 6

edited Mar 9, 2017 at 3:31

answered Mar 8, 2017 at 18:32

minigeek

3,1961 gold badge30 silver badges39 bronze badges

Collectives™ on Stack Overflow

Arrays stringing numbers

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related