Getting different value in array what I push

Question

I am working on angular project. I am facing error that last value of object shown in all array.

$scope.products = [{"product_id":"1", "price:80"},{"product_id":"2", "price:90"}]

Now i am using angular forEach method. actually I have much thing I product array so i use a order array where I I provide just id and value

angular.forEach($scope.products, function(value, key){
   $scope.order.product_id = value.product_id;
   $scope.order.price = value.price;
   $scope.orderProducts.push($scope.order);

})

but I get

$scope.orders = [{"product_id":"2", "price:90"},{"product_id":"2", "price:90"}]

on my console I saw

objet{{"product_id":"1", "price:80"}

but when I open then I get

 product_id:"2",
 price: "90"

its angular.forEach not .foreach.....how can that executed for you??check this docs.angularjs.org/api/ng/function/angular.forEach — Sa E Chowdary
– Sa E Chowdary, Commented Jun 2, 2017 at 7:05

Swati · Accepted Answer · 2017-06-02 07:03:01Z

2

angular.foreach($scope.products, function(value, key){
   $scope.order.product_id = $scope.products.product_id;
   $scope.order.price = $scope.products.price;
   $scope.orderProducts.push($scope.order);

})

Firstly you should use the value inside the function to get the value of the product at that index .

angular.foreach($scope.products, function(value, key){
   $scope.order.product_id = value.product_id;
   $scope.order.price = value.price;
   $scope.orderProducts.push($scope.order);

})

Next you are changing the same object in the iteration i.e. $scope.order which means the first order pushed in the orderProducts array is changed when you assign the new values in the next iteration . You should make a local variable and then push it in the array .

angular.foreach($scope.products, function(value, key){
   val orderObj = {};
   orderObj.product_id = value.product_id;
   orderObj.price = value.price;
   $scope.orderProducts.push(orderObj);

})

answered Jun 2, 2017 at 7:03

Swati

212 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sa E Chowdary Over a year ago

please dont do simple copy paste.....its angular.forEach not .foreach.....how can that executed for you??check this docs.angularjs.org/api/ng/function/angular.forEach

shaunhusain Over a year ago

@SaEChowdary question was pretty sloppy and unclear the answer here pointed at the actual problems both using the wrong object for getting the values and re-using the same object when pushing into the array, fact that the OP didn't take time to correctly copy and paste their own code shouldn't be a burden on those answering IMO

shaunhusain · Accepted Answer · 2017-06-02 06:52:03Z

1

angular.foreach($scope.products, function(value, key){
   $scope.order.product_id = $scope.products.product_id;
   $scope.order.price = $scope.products.price;
   $scope.orderProducts.push($scope.order);

})

In the function you are using $scope.products instead of the value and key you are iterating over. Some other things aren't clear in your question so if you get that corrected and still have a problem maybe review the question to make sure you include enough detail (ideally running sample)

answered Jun 2, 2017 at 6:52

shaunhusain

19.7k4 gold badges41 silver badges53 bronze badges

2 Comments

R. Sharma Over a year ago

My Mistake on typing question .. at code I am using value

shaunhusain Over a year ago

Think Swati has the rest of the issue then.

Rakesh Chand · Accepted Answer · 2017-06-02 06:54:56Z

0

Here is what you doing wrong

angular.foreach($scope.products, function(value, key){
   $scope.order.product_id = $scope.products.product_id;
   $scope.order.price = $scope.products.price;
   $scope.orderProducts.push($scope.order);
});

Repalce with

$scope.orderProducts = []
$scope.products = [{"product_id":"1", "price":80},{"product_id":"2", "price":90}]
angular.forEach($scope.products, function(value, key){
   $scope.orderProducts.push({
        product_id : value.product_id,
        price : value.price
   });
});

answered Jun 2, 2017 at 6:54

Rakesh Chand

3,1131 gold badge25 silver badges43 bronze badges

Collectives™ on Stack Overflow

Getting different value in array what I push

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related