correct approach with SignalR Hub and Controller class in ASP.NET MVC

Question

I try to send the received data from a webservice call to my javascript clients. What is the correct approach? Should I create a hubContext in the Controller class

//Controller 
var data = this.getData(_Ids);
var hubContext = GlobalHost.ConnectionManager.GetHubContext<Hubs.MyHub>();
hubContext.Clients.Client(cc.ConnectionId).receiveData(data);

and send the received data this way. Or should I create a controller in the Hub class to get the data there and send it in the Hub

//SignalR Hub
var data = new MyController().getData(_Ids);
Clients.Client(cpm.ConnectionId).receiveData(data);

qubits · Accepted Answer · 2018-06-02 21:54:14Z

0

You should never instantiate a Controller detached from the current execution context with the small exception being mocking as a part of unit testing.

Constructs like:

var data = new MyController().getData(_Ids);

Best be avoided. If deciding from the two its better to fetch the hub context from the controller.

Your example however is incomplete as you dont show whats inside of the getData(_Ids) method, you say you fetch the data from a web service?

Perhaps you can encapsulate the retrieval logic i.e getData(_Ids) in receiveData() within the Hub itself, or if you're calling this service in more places you could also define a static adapter helper class which will wrap around the calls to the web service and this adapter could later be used within receiveData() method of the hub.

Note that depending on the application your writing, its scope and functionality it might be a good idea to use some Dependency Injection framework like Autofac or Ninject and just inject IConnectionManager into the Controller through the constructor instead of instantiating it in the methods.

answered Jun 2, 2018 at 21:54

qubits

1,3073 gold badges21 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jonas Strt Over a year ago

Thank you for your answer. I tried the static adapter helper but in this case i had a problem with my authentication token. So i use the first approach.

Collectives™ on Stack Overflow

correct approach with SignalR Hub and Controller class in ASP.NET MVC

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related