Nodejs Mysql null value inserted on database

Question

app.post('', (req, res) => {
    pool.getConnection((err, connection) => {
        if (err) throw err
        console.log('connected as id' + connection.threadID)
        const params = req.body
        var name = params.name
        var tagline = params.tagline
        var description = params.description
        var image = params.image

        connection.query('INSERT INTO beers (name, tagline, description, image) VALUES (name,tagline,description,image)',
            (err, rows) => {
                connection.release()

                if (!err) {
                    res.send('Successfully added record of name' + params.name)
                } else {
                    console.log(err)
                }
            })

        console.log(req.body)
    })
})

You don't have any placeholders (?) for parameters in your query and you don't add any parameter values to your query. How do you think values (name, tagline ...) will magically pick up your variables? — derpirscher
– derpirscher, Commented Feb 3, 2022 at 7:36

lpizzinidev · Accepted Answer · 2022-02-03 08:20:15Z

1

As @derpirscher suggested, you should add the parameter values to the query.

Try to change your code like this:

    const { name, tagline, description, image } = req.body.params; 
    connection.query(
      'INSERT INTO beers (name, tagline, description, image) VALUES (?, ?, ?, ?)',
      [name, tagline, description, image],
      (err, rows) => {
        connection.release();

        if (!err) {
          res.send('Successfully added record of name' + params.name);
        } else {
          console.log(err);
        }
      }
    );

answered Feb 3, 2022 at 8:20

lpizzinidev

13.3k2 gold badges15 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Nodejs Mysql null value inserted on database

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related