php string in to javascript code with comma except last string

Question

I'm using a javascript plugin this is the line which I need help from u

<script type="text/javascript"> 
   $('ul#news').newswidget({ source: ['http://rss.news.yahoo.com/rss/us', 'http://rss.news.yahoo.com/rss/world', 'http://feeds.bbci.co.uk/news/rss.xml'],

I would like to add URL data from MySQL I'm using it with while loop like this

     $('ul#news').newswidget({ source:[<?php
while($rssrow = mysql_fetch_array($rss))
{
     echo "'"."$rssrow[rss_name]"."'".",";
}
?>],

It doesn't work properly :(. I need to get like URL,URL,RUL like this. that means no comma for the last one

any one please help me

cwallenpoole · Accepted Answer · 2011-09-01 02:45:42Z

3

You can actually do that pretty easily by a simple reorganization:

if($rssrow = mysql_fetch_array($rss))
{
    echo "'".$rssrow['rss_name']."'";
    while($rssrow = mysql_fetch_array($rss))
    {
         // note no quotes -- they are redundant
         // prepend the comma
         echo ","."'".$rssrow['rss_name']."'";
    }
}

It does make for an extra step for the reader, but it does have the benefit of not needing substring, a new array, or a flag.

edited Sep 1, 2011 at 2:45

answered Sep 1, 2011 at 2:32

cwallenpoole

82.4k26 gold badges132 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

NullUserException · Accepted Answer · 2011-09-01 02:29:51Z

2

You could just build the string and remove the last comma:

$result = '';
while($rssrow = mysql_fetch_array($rss))
{
     $result .= "'"."$rssrow[rss_name]"."'".",";
}

echo ($result != '') ? substr($result, 0, -1) : "''";

OR use implode():

$result = array();
while($rssrow = mysql_fetch_array($rss))
{
     $result[] = $rssrow[rss_name];
}
echo "'" . implode($result, "','") . "'";

(both of these methods will output '' if the result set is empty.)

answered Sep 1, 2011 at 2:29

NullUserException

85.8k31 gold badges212 silver badges239 bronze badges

Comments

user898741 · Accepted Answer · 2011-09-01 18:15:15Z

1

$urls = "";

while($rssrow = mysql_fetch_array($rss))
{
    $urls.= "'$rssrow[rss_name]',";
}

echo substr($urls, 0, -1);

answered Sep 1, 2011 at 18:15

user898741

Comments

Adrian Heine · Accepted Answer · 2011-09-02 09:50:17Z

1

I wonder why no comment points out that you should definitely escape your output. If an entry contains a ', all solutions aside from Dmitry F’s first will break badly.

$('ul#news').newswidget({ source:[<?php
$arr = array();
while($rssrow = mysql_fetch_array($rss))
{
  $arr[] = '"' . str_replace('"', '\"', $rssrow['rss_name']) . '"';
}
echo implode(',', $arr);
?>],

answered Sep 2, 2011 at 9:50

Adrian Heine

4,1493 gold badges32 silver badges43 bronze badges

Comments

Dmitry F · Accepted Answer · 2011-09-02 12:26:05Z

1

here is a little bit different approach:

<?php
$news = array(
'source' => array(
    'http://example.com',
    'http://example.com'
)
);
$news_json = json_encode($news);
?>

<script>
$('ul#news').newswidget(<?php echo $news_json; ?>);
</script>

another variation:

$url = array();
while($rssrow = mysql_fetch_array($rss))
{
    $url[] = '"' . $rssrow['rss_name'] . '"';
}
echo implode(',', $url);

edited Sep 2, 2011 at 12:26

answered Sep 1, 2011 at 2:34

Dmitry F

1,6701 gold badge15 silver badges20 bronze badges

1 Comment

Adrian Heine Over a year ago

Your second version looses the first entry.

Collectives™ on Stack Overflow

php string in to javascript code with comma except last string

5 Answers 5

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related