Inverted comma - php to javascript

Question

Consider this line of JavaScript

str += "onclick=runTest(" +  field + "," + atom[0] + ",'" + atom[1] + "');

In the browser, it renders as:

onclick="runTest(104,213,'Orsan" Miller');

There is an inverted comma between Orsan and Miller although in fact there was not any inverted comma, it's causing a bug.

atom[1] = Orsan Miller

'Orsan Miller' comes from DB query in PHP.

How can this be fixed?

is your first line of javascript a typo or are you really missing the closing quote? — ashansky
– ashansky, Commented Nov 21, 2011 at 21:58
@brianreavis And if you lived in Britain, you'd call it an "inverted comma". — eaj
– eaj, Commented Nov 21, 2011 at 22:00

brianreavis · Accepted Answer · 2011-11-21 22:00:06Z

2

You're missing some quotation marks and escaping... try this:

str += "onclick=\"runTest(" +  field + "," + atom[0] + ",'" + atom[1] + "')\"";

I prefer to use single quotes for readability, but that's just me:

str += 'onclick="runTest(' + field + ',' + atom[0] + ',\'' + atom[1] + '\')"';

answered Nov 21, 2011 at 22:00

brianreavis

11.5k3 gold badges45 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

k4t434sis · Accepted Answer · 2011-11-21 22:05:34Z

0

str += "onclick=runTest(" +  field + "," + atom[0] + ",'" + atom[1] + "')";

Is what you are looking for, it was fine except you forgot the final double quote.

answered Nov 21, 2011 at 22:05

k4t434sis

5194 silver badges17 bronze badges